Make ADIOS tests compatible with 2.9 and 2.10 #3128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We know we are not compatible and will do a minor DOLFINx release once ADIOS 2.10 is widely available.
I'll add a try except in the test, give me a few minutes to build adios 2.10 locally to make a fix |
|
@jhale I added a patch to the test. As the only thing that doesn't work with adios2 is the test, i think it is better to patch the test for backwards compatibility than restricting build versions |
|
Why not apply fixes to be compatible with 2.10? How much work would it be? |
francesco-ballarin
approved these changes
Apr 15, 2024
Ive changed the scope of the PR. We are now compatible with 3.10, given that try except clause in the adios tests (only Python interface changed from 2.9 to 2.10). |
jorgensd
changed the title
garth-wells
approved these changes
Apr 15, 2024
garth-wells
reviewed
Apr 15, 2024
jorgensd
reviewed
Apr 15, 2024
|
Looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We know we are not compatible with 2.10. Will do a minor DOLFINx release once ADIOS 2.10 is widely available.