CG3 triangle mesh support and VTK visualization of CG2 and CG3 meshes/functions #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to do to make this robust
Loads of similar code with slight variations, since the dolfin::generation::xxxMesh is initialized in a very different way than meshes from points
…to do to make this robust
* test read mesh data * add partition functions to python layer * add distributed mesh test * parametrize subset_comm in test * use enum for graph partitioners * some small fix and docstring improvement * reorder parameters for consistency * use type hint for return
Moved all vtk permutations to separate function. Changing how the file writers (also xdmf and hdf5) access the perturbation map. Moved mesh degree determination to separate function
…d note for future PR, and cleanup before PR of this branch
as the old implementation assumed that the permutation was (0,1,2,3) in Mesh.cpp, while the vtk_mapping was (0,1,3,2) (Due to lexiographic ordering in quads). Removing the duplication of mappings caused this change
|
It is nice to have VTK output, but for large scale, we want XDMF. Is this possible for higher order? Generally XDMF follows similar rules to VTK. If not, we should think about how to get it added. |
I can look into that, started with VTK since it was the easiest one to get up and running. |
chrisrichardson
approved these changes
Sep 19, 2019
garth-wells
requested changes
Sep 19, 2019
…lfinx into dokken/high-order-mesh
…s from XDMF and VTk
garth-wells
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposing VTKFile to write higher order meshes/functions to file
Adding ordering for CG3 elements with the VTK formating (Counter-clockwise).
Minor changes to quad meshes, as there was some weird duplication of ordering of cells compared to VTK (dolfin::generation generates lexiographic ordering, while VTK assumes counter clockwise).
Unit tests for higher order meshes added, explaining the ordering of cells