Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add needs_facet_permutations flag #383

Closed
mscroggs opened this issue Aug 17, 2021 · 0 comments · Fixed by #384
Closed

Add needs_facet_permutations flag #383

mscroggs opened this issue Aug 17, 2021 · 0 comments · Fixed by #384
Assignees
Labels
enhancement New feature or request

Comments

@mscroggs
Copy link
Member

mscroggs commented Aug 17, 2021

Currently, for all facet integrals, DOLFINx creates the entity permutation info and passes it into the kernel: see eg https://github.com/FEniCS/dolfinx/blob/3d11b33af6a41ebc596650b78ef347932b2b79c0/cpp/dolfinx/fem/assemble_matrix_impl.h#L474. Inside create_entity_permutations, all the entities are created (https://github.com/FEniCS/dolfinx/blob/1b0e5ed457fc57735c896e1732e231e3b8cdb47c/cpp/dolfinx/mesh/Topology.cpp#L246-L247). These entities can take up quite a bit of memory and aren't always needed.

The code generated by FFCx for a form should have a bool (called something like needs_facet_permutations) that indicates whether or not this informations is actually needed in the kernel. I think it is only needed when a term like a["-"] * b["+"] is in the form.

@mscroggs mscroggs self-assigned this Aug 17, 2021
@mscroggs mscroggs added the enhancement New feature or request label Aug 17, 2021
@mscroggs mscroggs changed the title Add needs_quadrature_transformation flag Add needs_facet_permutations flag Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant