Quadrature permutations for DG and some negating of vector-valued spaces #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0884f12.
mscroggs
changed the title
mscroggs
requested review from
michalhabera,
chrisrichardson and
garth-wells
| const double* restrict coordinate_dofs, const int* entity_local_index, | ||
| const uint8_t* restrict quadrature_permutation, | ||
| const bool* edge_reflections, const bool* face_reflections, | ||
| const uint8_t* face_rotations); |
There was a problem hiding this comment.
You didn't document face_rotations. Also, it feels a bit weird now. If I understand correctly, in general, for vector dofs you need to know face_rotations for a cell integrals too, right? So for a interior facet integrals, isnt now information about rotations of codim 1 entities, facets, duplicated?
There was a problem hiding this comment.
quadrature_permutation has information about the rotation from two cells either side, while the other inputs are information about the different entities on one cell. But I agree that restructuring what these inputs are at some point is a good idea.
…fcx into mscroggs/move_base_perms_to_ffc
michalhabera
approved these changes
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dof_permutations.pyUFC_HEADER_DECLfromufc.hinstead of duplicating it.entity_block_sizeis removed, as this is not constant for higher order vector spaces. Instead, this functionality is now included in the calculate of the base dof permutations.This pull request resolves FEniCS/dolfinx#742, and partially covers FEniCS/dolfinx#736 and FEniCS/dolfinx#737
This is an updated version of #190, and is twinned with FEniCS/dolfinx#770.