Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity DOFs for quadrature element #367

Closed

Conversation

mscroggs
Copy link
Member

These changes follow on from #365, but I'm less sure about these.

These changes add entity dofs and entity closure dofs to ufc_finite_element (for quadrature elements only).

This allows FEniCS/dolfinx#1585 to be done.

This PR is into my other PR so we can either merge this with those changes, or merge that and rework this afterwards.

@mscroggs
Copy link
Member Author

An alternative to doing it this way would be to write both entity dofs and entity closure dofs into the ufc_dofmap, then dolfinx can get them both from there instead of from the FiniteElement.

@mscroggs mscroggs marked this pull request as draft June 23, 2021 07:53
@mscroggs
Copy link
Member Author

Closing this. The more I think about it, the simpler the alternative using ufc_dofmap seems

@mscroggs mscroggs closed this Jun 23, 2021
@mscroggs mscroggs deleted the mscroggs/get_entity_dofs_from_basix branch June 23, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant