Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix expression signature for expressions with ufl domain from constant #532

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Fix expression signature for expressions with ufl domain from constant #532

merged 1 commit into from
Sep 1, 2022

Conversation

jorgensd
Copy link
Sponsor Member

@jorgensd jorgensd commented Sep 1, 2022

Resolves Resolve FEniCS/dolfinx#2342

@jorgensd jorgensd added the bug Something isn't working label Sep 1, 2022
chrisrichardson
chrisrichardson approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@chrisrichardson chrisrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me

@jorgensd jorgensd merged commit 943263d into main Sep 1, 2022
@jorgensd jorgensd deleted the dokken/expr-const-signature branch September 1, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisrichardson chrisrichardson chrisrichardson approved these changes

@nate-sime nate-sime nate-sime approved these changes

@garth-wells garth-wells Awaiting requested review from garth-wells

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dolfinx.fem.Expression containing only a dolfinx.fem.Constant fails
3 participants
@jorgensd @chrisrichardson @nate-sime