Add variant to EnrichedElement, TensorProductElement, etc #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wence-
reviewed
Sep 15, 2022
wence-
reviewed
Oct 10, 2022
ufl/finiteelement/elementlist.py
Outdated
Comment on lines
203
to
206
| register_element2("SminusE", 1, HCurl, "covariant Piola", (1, None), cubes[1:3]) | ||
| register_element2("SminusF", 1, HDiv, "contravariant Piola", (1, None), cubes[1:2]) | ||
| register_element2("SminusDiv", 1, HDiv, "contravariant Piola", (1, None), cubes[1:3]) | ||
| register_element2("SminusCurl", 1, HCurl, "covariant Piola", (1, None), cubes[1:3]) |
There was a problem hiding this comment.
Why are these part of this change?
There was a problem hiding this comment.
I think these "Sminus" elements aren't in the FEniCS UFL yet? Anyways I have cleaned the commit history.
pbrubeck
force-pushed
the
pbrubeck/feature/composite-variant
branch
2 times, most recently
from
ac7bc17
to
be741d0
Compare
pbrubeck
force-pushed
the
pbrubeck/feature/composite-variant
branch
from
be741d0
to
cb329cc
Compare
pbrubeck
added a commit
to firedrakeproject/ufl
that referenced
this pull request
Nov 1, 2022
* get variant for composite elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lets composite elements return the
variantproperty of their sub-elements. When the sub-elements are of different variants,variant()returnsNone.