Possible fix for taking scalar derivatives of vector coefficients using coefficient derivative maps #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. a scalar. Also adding a test.
wence-
reviewed
Oct 10, 2022
mscroggs
approved these changes
Sep 12, 2023
cianwilson
added a commit
to cianwilson/ufl
that referenced
this pull request
Sep 26, 2023
…lar. Also adding a test. Merged into main in FEniCS#124. Commits squashed for this patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the argument
vis scalar thenlen(v.ufl_shape)= 0 and choosing the indices based on:is not valid. Specifically
v[oi2]will produce the error (see #123):This PR makes scalar
va special case so that the product can be evaluated as a tensor scalar product.It also adds a unit test for this case, which fails with current main.