Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement sobolev_space() for BrokenElement and WithMapping #126

Merged
merged 2 commits into from
Oct 12, 2022

Conversation

pbrubeck
Copy link
Contributor

Since #117, sobolev_space() is an abstract method, and a couple elements were not implementing this method.

Copy link
Collaborator

@dham dham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I just noticed this issue over on #122 so I'm very happy you've fixed it. I'm just not sure that what is proposed for WithMapping is correct.

ufl/finiteelement/hdivcurl.py Outdated Show resolved Hide resolved
@pbrubeck pbrubeck requested a review from dham October 12, 2022 08:50
@dham dham merged commit 4e3868d into FEniCS:main Oct 12, 2022
@dham dham deleted the pbrubeck/fix/sobolev-broken-mapped branch October 12, 2022 09:08
pbrubeck added a commit to firedrakeproject/ufl that referenced this pull request Nov 1, 2022
Implement sobolev_space() for BrokenElement and WithMapping
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants