Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix str #162

Merged
merged 1 commit into from
May 15, 2023
Merged

fix str #162

merged 1 commit into from
May 15, 2023

Conversation

ksagiyam
Copy link
Contributor

This PR fixes str.

from ufl import *
  

elem = FiniteElement("Q", quadrilateral, 1)
print(elem)

currently prints:

<None1 on a quadrilateral>

instead of:

<Q1 on a quadrilateral>

dham
dham reviewed May 11, 2023
View reviewed changes
Copy link
Collaborator

@dham dham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is obviously correct. Can you just put in a tiny test using the example you gave, just so this errors if someone at some point clobbers your change.

@ksagiyam
Copy link
Contributor Author

Sure. Added a test.

@mscroggs mscroggs merged commit d2dfbef into FEniCS:main May 15, 2023
11 checks passed
@ksagiyam ksagiyam deleted the ksagiyam/fix_str branch May 15, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dham dham dham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ksagiyam @dham @mscroggs