Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atan_2 changed to atan2 #196

Merged
merged 1 commit into from
Sep 12, 2023
Merged

atan_2 changed to atan2 #196

merged 1 commit into from
Sep 12, 2023

Conversation

ignacia-fp
Copy link
Collaborator

Appearances of atan_2 have been changed to atan2. This functions is defined inside two different objects and also as a UFL operator. Maybe you could find another name or way to define this function to avoid name collisions in the code.

@mscroggs mscroggs linked an issue Sep 12, 2023 that may be closed by this pull request
@mscroggs mscroggs merged commit 8f44275 into main Sep 12, 2023
19 checks passed
@mscroggs mscroggs deleted the replace_atan_2 branch September 12, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

atan2 vs atan_2 - documentaion error
2 participants