topological_sorting
: replace ineffective continue
with break
#229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of issue
The
continue
statement inufl.utils.sorting.topological_sorting
(https://github.com/FEniCS/ufl/blob/main/ufl/utils/sorting.py#L25) has no effect: it causes execution to jump to the beginning of the innerfor
loop, which would happen anyway since there is no code following thecontinue
inside the loop. It should be abreak
statement, since there is no need to continue searching the edges oncenode
has been removed fromS
.Description of changes
This pull request replaces the offending
continue
with abreak
.