Fix zero simplification in BaseForm.__add__ #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trimmed serendipity
Merge fenics
Merge FEniCS
Ksagiyam/merge upstream
Update to current fenics master.
remove spurious names
Dolci/merge upstream 2
…date Merge upstream
…/merge_upstream_partial
nbouziani
changed the title
mscroggs
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the rule for simplifying the sum of a
BaseFormwith aufl.constantvalue.Zero. The rule used to be that anyZerothat is added to aBaseFormis dismissed if that zero is scalar and doesn't have free indices. This logic, inherited fromufl.Exprobjects, doesn't apply toBaseFormobjects and should be removed.