Add workflow to run DOLFINx and FFCx tests #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wence-
approved these changes
Jan 20, 2022
There was a problem hiding this comment.
I think this looks good. The firedrake build is rather heavier than dolfin so we'll probably just pull a container rather than building from scratch.
It's not as urgent since we (for zenodo-release purposes) maintain a UFL fork that just points at known good UFL-main commits (this is currently updated manually, though with these changes we could update it automatically.
garth-wells
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a PR is opened, the FFCx and DOLFINx tests will be run using the updated UFL.
This will make is easier to catch when changes to UFL might require changes to FFCx and DOLFINx.
I think it would be sensible to add a similar CI for Firedrake at some point, if someone from Firedrake wants to set something similar up.