[feature][ElementTypes] Added 4d element types #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…seract (4d cube).
wence-
approved these changes
Apr 8, 2022
|
Thanks. I'm not sure if there are other places in UFL that need adjustment. This patch worked for me though. |
|
Thanks for taking care of it. |
|
Merging this into a side branch so I can correctly merge the changes to cell on main into this PR |
mscroggs
merged commit ef3c7ae
into
FEniCS:mscroggs/4d-element-types
0 of 11 checks passed
Merged
mscroggs
added a commit
that referenced
this pull request
Aug 10, 2023
* [feature][ElementTypes] Added 4d types pentatope (4d simplex) and tesseract (4d cube). (#95) Co-authored-by: Jack S. Hale <mail@jackhale.co.uk> Co-authored-by: David A. Ham <david.ham@imperial.ac.uk> Co-authored-by: Matthew Scroggs <matthew.w.scroggs@gmail.com> * fix merge, add test --------- Co-authored-by: dr-robertk <dr-robertk@users.noreply.github.com> Co-authored-by: Jack S. Hale <mail@jackhale.co.uk> Co-authored-by: David A. Ham <david.ham@imperial.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 4d element types to cell.py and elementlist.py.
While for the 4d cube there seems to be only one name, tesseract, for the 4d simplex it's not so clear.
Here I chose pentatope following the paper https://www.sciencedirect.com/science/article/abs/pii/S0168927421000994.