Skip to content

Commit

Permalink
Add HDR10 Metadata Tests
Browse files Browse the repository at this point in the history 
Signed-off-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>
Signed-off-by: Vittorio Giovara <vittorio.giovara@gmail.com>
  • Loading branch information
@dwbuiten @kodawah
dwbuiten authored and kodawah committed Feb 14, 2019
1 parent ed27fb4 commit 7c36121
Show file tree
Hide file tree
Showing 2 changed files with 169 additions and 3 deletions.
12 changes: 9 additions & 3 deletions test/Makefile
View file
Expand Up @@ -26,10 +26,10 @@ CXXFLAGS += -g -Wall -Wextra -pthread -std=c++11 -fvisibility=hidden

# All tests produced by this Makefile. Remember to add new tests you
# created to the list.
TESTS = indexer
TESTS = indexer hdr

# All the sample files we need to sync
SAMPLES = test.mp4
SAMPLES = test.mp4 hdr10tags-both.mkv hdr10tags-container.mkv hdr10tags-stream.mp4

# All Google Test headers. Usually you shouldn't change this
# definition.
Expand All @@ -40,7 +40,7 @@ GTEST_HEADERS = $(GTEST_DIR)/include/gtest/*.h $(GTEST_DIR)/include/gtest/intern
all: $(TESTS)

run: all
@for i in "$(TESTS)"; do \
@for i in $(TESTS); do \
./$$i; \
done

Expand Down Expand Up @@ -80,8 +80,14 @@ gtest_main.a: gtest-all.o gtest_main.o
tests.o: $(USER_DIR)/test/tests.cpp $(USER_DIR)/include/ffms.h $(GTEST_HEADERS)
$(CXX) $(CPPFLAGS) $(CXXFLAGS) -c $(USER_DIR)/test/tests.cpp

hdr.o: $(USER_DIR)/test/hdr.cpp $(USER_DIR)/include/ffms.h $(GTEST_HEADERS)
$(CXX) $(CPPFLAGS) $(CXXFLAGS) -c $(USER_DIR)/test/hdr.cpp

indexer.o: $(USER_DIR)/test/indexer.cpp $(USER_DIR)/include/ffms.h $(GTEST_HEADERS)
$(CXX) $(CPPFLAGS) $(CXXFLAGS) -c $(USER_DIR)/test/indexer.cpp

indexer: indexer.o tests.o gtest_main.a ../src/core/libffms2.la
../libtool --tag=CXX --mode=link $(CXX) $(CPPFLAGS) $(CXXFLAGS) -o indexer indexer.o tests.o gtest_main.a -lavutil ../src/core/libffms2.la

hdr: hdr.o gtest_main.a ../src/core/libffms2.la
../libtool --tag=CXX --mode=link $(CXX) $(CPPFLAGS) $(CXXFLAGS) -o hdr hdr.o gtest_main.a -lavutil ../src/core/libffms2.la
160 changes: 160 additions & 0 deletions test/hdr.cpp
View file
@@ -0,0 +1,160 @@
#include <cfloat>
#include <cmath>
#include <cstring>
#include <string>
#include <vector>

#include <ffms.h>
#include <gtest/gtest.h>

#include "tests.h"

typedef struct HDR10Data {
double MasteringDisplayPrimariesX[3];
double MasteringDisplayPrimariesY[3];
double MasteringDisplayWhitePointX;
double MasteringDisplayWhitePointY;
double MasteringDisplayMinLuminance;
double MasteringDisplayMaxLuminance;
} HDR10Data;

#define TEST_DOUBLE(A, B) ((A == B) || (fabs(A - B) < DBL_EPSILON))

const HDR10Data StreamHDR10Data = {
{ 35400.0 / 50000.0, 8500.0 / 50000.0, 6550.0 / 50000.0 },
{ 14599.0 / 50000.0 , 39850.0 / 50000.0 , 2300.0 / 50000.0 },
15634.0 / 50000.0,
16450.0 / 50000.0,
10.0 / 10000.0,
10000000.0 / 10000.0
};

const HDR10Data ContainerHDR10Data {
{ 34000.0 / 50000.0, 13250.0 / 50000.0, 7500.0 / 50000.0 },
{ 16000.0 / 50000.0, 34500.0 / 50000.0, 3000.0 / 50000.0 },
15635.0 / 50000.0,
16450.0 / 50000.0,
100.0 / 10000.0,
10000000.0 / 10000.0
};

namespace {

class HDR10Test : public ::testing::Test {
protected:
virtual void SetUp();
virtual void TearDown();
bool DoIndexing(std::string);

FFMS_Indexer* indexer;
FFMS_Index* index;
int video_track_idx;
FFMS_VideoSource* video_source;
const FFMS_VideoProperties* VP;

FFMS_ErrorInfo E;
char ErrorMsg[1024];

std::string SamplesDir;
};

void HDR10Test::SetUp() {
indexer = nullptr;
index = nullptr;
video_track_idx = -1;
video_source = nullptr;
VP = nullptr;
E.Buffer = ErrorMsg;
E.BufferSize = sizeof(ErrorMsg);
SamplesDir = STRINGIFY(SAMPLES_DIR);

FFMS_Init(0,0);
}

void HDR10Test::TearDown() {
FFMS_DestroyIndex(index);
FFMS_DestroyVideoSource(video_source);
FFMS_Deinit();
}

bool HDR10Test::DoIndexing(std::string file_name) {
indexer = FFMS_CreateIndexer(file_name.c_str(), &E);
NULL_CHECK(indexer);
FFMS_TrackTypeIndexSettings(indexer, FFMS_TYPE_VIDEO, 1, 0);

index = FFMS_DoIndexing2(indexer, 0, &E);
NULL_CHECK(index);

video_track_idx = FFMS_GetFirstTrackOfType(index, FFMS_TYPE_VIDEO, &E);
EXPECT_GE(0, video_track_idx);

video_source = FFMS_CreateVideoSource(file_name.c_str(), video_track_idx, index, 1, FFMS_SEEK_NORMAL, &E);
NULL_CHECK(video_source);

VP = FFMS_GetVideoProperties(video_source); // Can't fail

return true;
}

TEST_F(HDR10Test, StreamData) {
std::string FilePath = SamplesDir + "/hdr10tags-stream.mp4";

ASSERT_TRUE(DoIndexing(FilePath));

ASSERT_TRUE(!!VP->HasMasteringDisplayPrimaries);
for (int i = 0; i < 3; i++) {
ASSERT_TRUE(TEST_DOUBLE(VP->MasteringDisplayPrimariesX[i], StreamHDR10Data.MasteringDisplayPrimariesX[i]));
ASSERT_TRUE(TEST_DOUBLE(VP->MasteringDisplayPrimariesY[i], StreamHDR10Data.MasteringDisplayPrimariesY[i]));
}
ASSERT_TRUE(TEST_DOUBLE(VP->MasteringDisplayWhitePointX, StreamHDR10Data.MasteringDisplayWhitePointX));
ASSERT_TRUE(TEST_DOUBLE(VP->MasteringDisplayWhitePointY, StreamHDR10Data.MasteringDisplayWhitePointY));

ASSERT_TRUE(!!VP->HasMasteringDisplayLuminance);
ASSERT_TRUE(TEST_DOUBLE(VP->MasteringDisplayMinLuminance, StreamHDR10Data.MasteringDisplayMinLuminance));
ASSERT_TRUE(TEST_DOUBLE(VP->MasteringDisplayMaxLuminance, StreamHDR10Data.MasteringDisplayMaxLuminance));
}

TEST_F(HDR10Test, ContainerData) {
std::string FilePath = SamplesDir + "/hdr10tags-container.mkv";

ASSERT_TRUE(DoIndexing(FilePath));

// Stream HDR metadata should be used.
ASSERT_TRUE(!!VP->HasMasteringDisplayPrimaries);
for (int i = 0; i < 3; i++) {
ASSERT_TRUE(TEST_DOUBLE(VP->MasteringDisplayPrimariesX[i], ContainerHDR10Data.MasteringDisplayPrimariesX[i]));
ASSERT_TRUE(TEST_DOUBLE(VP->MasteringDisplayPrimariesY[i], ContainerHDR10Data.MasteringDisplayPrimariesY[i]));
}
ASSERT_TRUE(TEST_DOUBLE(VP->MasteringDisplayWhitePointX, ContainerHDR10Data.MasteringDisplayWhitePointX));
ASSERT_TRUE(TEST_DOUBLE(VP->MasteringDisplayWhitePointY, ContainerHDR10Data.MasteringDisplayWhitePointY));

ASSERT_TRUE(!!VP->HasMasteringDisplayLuminance);
ASSERT_TRUE(TEST_DOUBLE(VP->MasteringDisplayMinLuminance, ContainerHDR10Data.MasteringDisplayMinLuminance));
ASSERT_TRUE(TEST_DOUBLE(VP->MasteringDisplayMaxLuminance, ContainerHDR10Data.MasteringDisplayMaxLuminance));
}

TEST_F(HDR10Test, StreamAndContainerData) {
std::string FilePath = SamplesDir + "/hdr10tags-both.mkv";

ASSERT_TRUE(DoIndexing(FilePath));

// Stream HDR metadata should be used.
ASSERT_TRUE(!!VP->HasMasteringDisplayPrimaries);
for (int i = 0; i < 3; i++) {
ASSERT_TRUE(TEST_DOUBLE(VP->MasteringDisplayPrimariesX[i], StreamHDR10Data.MasteringDisplayPrimariesX[i]));
ASSERT_TRUE(TEST_DOUBLE(VP->MasteringDisplayPrimariesY[i], StreamHDR10Data.MasteringDisplayPrimariesY[i]));
}
ASSERT_TRUE(TEST_DOUBLE(VP->MasteringDisplayWhitePointX, StreamHDR10Data.MasteringDisplayWhitePointX));
ASSERT_TRUE(TEST_DOUBLE(VP->MasteringDisplayWhitePointY, StreamHDR10Data.MasteringDisplayWhitePointY));

ASSERT_TRUE(!!VP->HasMasteringDisplayLuminance);
ASSERT_TRUE(TEST_DOUBLE(VP->MasteringDisplayMinLuminance, StreamHDR10Data.MasteringDisplayMinLuminance));
ASSERT_TRUE(TEST_DOUBLE(VP->MasteringDisplayMaxLuminance, StreamHDR10Data.MasteringDisplayMaxLuminance));
}

} //namespace

int main(int argc, char **argv) {
::testing::InitGoogleTest(&argc, argv);
return RUN_ALL_TESTS();
}

0 comments on commit 7c36121

Please sign in to comment.