Skip to content

Commit

Permalink
pythongh-107630: Fix Remaining Subinterpreters Crashes on Py_TRACE_RE…
Browse files Browse the repository at this point in the history
…FS Builds (pythongh-107750)

This is a follow-up to pythongh-107567 and pythongh-107733.

We skip test_basic_multiple_interpreters_deleted_no_reset on tracerefs builds.  The test breaks interpreter isolation a little, which doesn't work well with Py_TRACE_REFS builds, so I feel fine about skipping the test.
  • Loading branch information
ericsnowcurrently committed Aug 7, 2023
1 parent 5dc825d commit 707018c
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions Lib/test/test_import/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -2555,6 +2555,12 @@ def test_basic_multiple_interpreters_main_no_reset(self):
def test_basic_multiple_interpreters_deleted_no_reset(self):
# without resetting; already loaded in a deleted interpreter

if hasattr(sys, 'getobjects'):
# It's a Py_TRACE_REFS build.
# This test breaks interpreter isolation a little,
# which causes problems on Py_TRACE_REF builds.
raise unittest.SkipTest('crashes on Py_TRACE_REFS builds')

# At this point:
# * alive in 0 interpreters
# * module def may or may not be loaded already
Expand Down

0 comments on commit 707018c

Please sign in to comment.