Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: include Python 3.10 #23

Merged
merged 2 commits into from
Oct 11, 2021
Merged

tests: include Python 3.10 #23

merged 2 commits into from
Oct 11, 2021

Conversation

henryiii
Copy link
Collaborator

No description provided.

@@ -37,6 +37,11 @@ jobs:
steps:
- uses: actions/checkout@v2

- uses: actions/setup-python@v2
with:
python-version "3.10"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to do, no?

Suggested change
python-version "3.10"
python-version: ${{ matrix.py }}

Copy link
Collaborator Author

@henryiii henryiii Oct 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nox action is exactly the same as activating all installed versions of Python. Except it's not picking up 3.10 for some reason - maybe it's pinned to an old list somehow. This fixes is by adding the missing version.

Using setup-python with matrix.py + pipx run nox would be another way to go, no setup-nox required. Can change if you want.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is very simple (https://github.com/excitedleigh/setup-nox/blob/main/src/setup-python.ts), so I don't really see why 3.10 isn't being picked up; I assumed it would be due to looking at that code.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FFY00 FFY00 enabled auto-merge (rebase) October 11, 2021 19:56
@FFY00 FFY00 merged commit 17169d6 into main Oct 11, 2021
@henryiii henryiii deleted the henryiii/tests/310again branch October 11, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants