fix: support getting git info on a tag #5
Conversation
|
Sorry for the delay! I think I will be using |
|
Didn't see it in the changelog, does 0.0.4 support this, or is automatic tagging from an actual tag still unsupported? |
|
No, I am waiting for pypa/setuptools_scm#580, but I guess we could merge this in the meanwhile. |
|
Was hoping the release would clean up some of my workarounds, but this one and pypa/twine#753 are the main problems. |
|
And the missing |
|
That one is fixed, 2.2 metadata will only be used when needed. I guess I can make a new release with this PR. |
Ah, yes. I will add an option for that and make a release after. |
|
Great, will remove the 2.2 workaround then. |
|
Okay, as soon as you do, I'll update. Since you don't use GitHub releases so subscribing doesn't do anything, I'll just check back occasionally. |
|
I can easily add a test to fix coverage if you want me to. |
|
(Basically just asking for a mutex lock, in case you have started doing it already) |
Head branch was pushed to by a user without write access
|
Done. |
|
PS https://github.com/github/gitignore/blob/master/Python.gitignore is a good source for a CC0 gitignore basis. ;) I immediately noticed that |
|
Seems like the tests are failing due to fragile version unpacking. Perhaps we could just use |
|
Nah, I accidentally put the output before the patch into the monkey patched tests. I'm dumping a real output (grabbed from a random repository) in now. |
| def test_vcs_git_repo_exact(mocker, package_no_version): | ||
| mocker.patch( | ||
| 'subprocess.check_output', | ||
| side_effect=[b'v2.1.1-0-g5ce8958'], |
There was a problem hiding this comment.
The whole point of the patch is so that the output will always look something like this; adding --long will always produce the last two items. The tests originally didn't have the last two items.
There was a problem hiding this comment.
Now it might be broken. :) I can look into it in a little bit.
Signed-off-by: Filipe Laíns <lains@riseup.net> Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Closes #4 with a suggested possible fix.