Skip to content

Commit

Permalink
avfilter/af_afir: add minp/maxp options to control latency and speed
Browse files Browse the repository at this point in the history
  • Loading branch information
richardpl committed Nov 8, 2018
1 parent 698e67b commit 36348d7
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 2 deletions.
10 changes: 10 additions & 0 deletions doc/filters.texi
Expand Up @@ -1217,6 +1217,16 @@ Set video stream size. This option is used only when @var{response} is enabled.

@item rate
Set video stream frame rate. This option is used only when @var{response} is enabled.

@item minp
Set minimal partition size used for convolution. Default is @var{16}.
Allowed range is from @var{16} to @var{65536}.
Lower values decreases latency at cost of higher CPU usage.

@item maxp
Set maximal partition size used for convolution. Default is @var{65536}.
Allowed range is from @var{16} to @var{65536}.
Lower values decreases latency at cost of higher CPU usage.
@end table

@subsection Examples
Expand Down
6 changes: 4 additions & 2 deletions libavfilter/af_afir.c
Expand Up @@ -310,8 +310,8 @@ static int convert_coeffs(AVFilterContext *ctx)
if (s->nb_taps <= 0)
return AVERROR(EINVAL);

for (n = 4; (1 << n) < s->nb_taps; n++);
N = FFMIN(n, 16);
for (n = av_log2(s->minp); (1 << n) < s->nb_taps; n++);
N = FFMIN(n, av_log2(s->maxp));
s->ir_length = 1 << n;
s->fft_length = (1 << (N + 1)) + 1;
s->part_size = 1 << (N - 1);
Expand Down Expand Up @@ -786,6 +786,8 @@ static const AVOption afir_options[] = {
{ "channel", "set IR channel to display frequency response", OFFSET(ir_channel), AV_OPT_TYPE_INT, {.i64=0}, 0, 1024, VF },
{ "size", "set video size", OFFSET(w), AV_OPT_TYPE_IMAGE_SIZE, {.str = "hd720"}, 0, 0, VF },
{ "rate", "set video rate", OFFSET(frame_rate), AV_OPT_TYPE_VIDEO_RATE, {.str = "25"}, 0, INT32_MAX, VF },
{ "minp", "set min partition size", OFFSET(minp), AV_OPT_TYPE_INT, {.i64=16}, 16, 65536, AF },
{ "maxp", "set max partition size", OFFSET(maxp), AV_OPT_TYPE_INT, {.i64=65536}, 16, 65536, AF },
{ NULL }
};

Expand Down
2 changes: 2 additions & 0 deletions libavfilter/af_afir.h
Expand Up @@ -46,6 +46,8 @@ typedef struct AudioFIRContext {
int w, h;
AVRational frame_rate;
int ir_channel;
int minp;
int maxp;

float gain;

Expand Down

0 comments on commit 36348d7

Please sign in to comment.