Skip to content

Commit

Permalink
avformat/rmdec: Do not pass mime type in rm_read_multi() to ff_rm_rea…
Browse files Browse the repository at this point in the history
…d_mdpr_codecdata()

Fixes: use after free()
Fixes: rmdec-crash-ffe85b4cab1597d1cfea6955705e53f1f5c8a362

Found-by: Paul Ch <paulcher@icloud.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
  • Loading branch information
michaelni committed Jul 5, 2018
1 parent 2b46ebd commit a7e032a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion libavformat/rmdec.c
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,7 @@ static int rm_read_multi(AVFormatContext *s, AVIOContext *pb,

size2 = avio_rb32(pb);
ret = ff_rm_read_mdpr_codecdata(s, s->pb, st2, st2->priv_data,
size2, mime);
size2, NULL);
if (ret < 0)
return ret;
}
Expand Down

1 comment on commit a7e032a

@wqazzz
Copy link

@wqazzz wqazzz commented on a7e032a May 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.