Extract blacklisted? method for Ruby implementation

FGRibreau · Mar 21, 2016 · 4afe036 · 4afe036
1 parent 0461b2d
commit 4afe036
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/platform/ruby/mail_checker.rb b/platform/ruby/mail_checker.rb
@@ -8,7 +8,7 @@ module MailChecker
   def self.valid?(email)
     return false unless valid_email?(email)
 
-    !extract_all_domain_suffixes(email).any? { |domain| BLACKLIST.include?(domain) }
+    !blacklisted?(email)
   end
 
   def self.valid_email?(email)
@@ -17,8 +17,12 @@ def self.valid_email?(email)
     email =~ EMAIL_REGEX
   end
 
+  def self.blacklisted?(email)
+    extract_all_domain_suffixes(email).any? { |domain| BLACKLIST.include?(domain) }
+  end
+
   def self.extract_all_domain_suffixes(email)
-    domain = email.gsub(/.+@([^.]+)/, '\1').downcase
+    domain = email.to_s.gsub(/.+@([^.]+)/, '\1').downcase
 
     domain_components = domain.split('.')
 

diff --git a/platform/ruby/mail_checker.tmpl.rb b/platform/ruby/mail_checker.tmpl.rb
@@ -8,7 +8,7 @@ module MailChecker
   def self.valid?(email)
     return false unless valid_email?(email)
 
-    !extract_all_domain_suffixes(email).any? { |domain| BLACKLIST.include?(domain) }
+    !blacklisted?(email)
   end
 
   def self.valid_email?(email)
@@ -17,8 +17,12 @@ def self.valid_email?(email)
     email =~ EMAIL_REGEX
   end
 
+  def self.blacklisted?(email)
+    extract_all_domain_suffixes(email).any? { |domain| BLACKLIST.include?(domain) }
+  end
+
   def self.extract_all_domain_suffixes(email)
-    domain = email.gsub(/.+@([^.]+)/, '\1').downcase
+    domain = email.to_s.gsub(/.+@([^.]+)/, '\1').downcase
 
     domain_components = domain.split('.')