Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing of matching structure from array to map for golang #296

Merged
merged 1 commit into from
Jan 3, 2021
Merged

Changing of matching structure from array to map for golang #296

merged 1 commit into from
Jan 3, 2021

Conversation

maranqz
Copy link
Contributor

@maranqz maranqz commented Dec 29, 2020

Realization of #295

@FGRibreau FGRibreau merged commit ce9423e into FGRibreau:master Jan 3, 2021
@FGRibreau
Copy link
Owner

Thanks @maranqz! Released in v4.0.3!

However npm run test:go seems to hang, any idea why?

docker run -i -v $(pwd):/app -w /app golang:1.13-alpine3.10 go test ./...

Same with golang:1.15.6-alpine3.12 could you please help me fix it?

@maranqz
Copy link
Contributor Author

maranqz commented Jan 3, 2021 •
edited

Hello,

I cannot reproduce this issue on neither windows 10 nor wsl (Ubuntu 20).
image

@FGRibreau
Copy link
Owner

Indeed after a second run it went back from freezing, perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maranqz @FGRibreau