Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single-line comment error #130

Closed
markkramerus opened this issue Jan 23, 2020 · 3 comments · Fixed by #141
Closed

Single-line comment error #130

markkramerus opened this issue Jan 23, 2020 · 3 comments · Fixed by #141
Assignees
@kjmahalingam
Labels
added to backlog Added to the team's Jira backlog bug Something isn't working released Available in an official SUSHI release

Comments

@markkramerus
Copy link
Collaborator

SUSHI flags an error on this line:
Parent: Observation //USCoreObservationLab

But it is OK with this line:
Parent: Observation // USCoreObservationLab

The only difference is the space after //. The space should not be necessary.
@kjmahalingam kjmahalingam self-assigned this Jan 23, 2020
@kjmahalingam kjmahalingam added added to backlog Added to the team's Jira backlog bug Something isn't working labels Jan 23, 2020
@kjmahalingam
Copy link
Contributor

I briefly investigated this earlier, and I found an interesting side effect.

This works:
// Comment

This doesn't work:
//Comment

This does work:
//Comment Comment

It seems like ANTLR is probably expecting some sort of whitespace in the comment. I can't figure out why that is, but I'll try to dig in some more tomorrow.

@kjmahalingam kjmahalingam mentioned this issue Jan 24, 2020
Merged
@cmoesel cmoesel added the merged label Jan 24, 2020
@cmoesel
Copy link
Member

cmoesel commented Jan 24, 2020

Re-opening until it's released.

@cmoesel cmoesel reopened this Jan 24, 2020
@jafeltra jafeltra mentioned this issue Jan 24, 2020
Closed
@cmoesel
Copy link
Member

cmoesel commented Jan 24, 2020

Fixed in 0.6.2

@cmoesel cmoesel closed this as completed Jan 24, 2020
@cmoesel cmoesel added the released Available in an official SUSHI release label Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kjmahalingam kjmahalingam

Labels
added to backlog Added to the team's Jira backlog bug Something isn't working released Available in an official SUSHI release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix line comments in grammar to allow for no whitespace FHIR/sushi
3 participants
@markkramerus @cmoesel @kjmahalingam