New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix line comments in grammar to allow for no whitespace #141

Merged

cmoesel merged 2 commits into master from fix-comments

Jan 24, 2020

Contributor

kjmahalingam commented Jan 24, 2020

Fixes #130

I tested against fsh-mcode and verified that there's no diff in output when using master or using this branch.


          Fix line comments in grammar to allow for no whitespace

0de6a01

kjmahalingam requested review from cmoesel, mint-thompson, jafeltra and ngfreiter

January 24, 2020 20:21


          Merge branch 'master' into fix-comments

3c6e5ec

cmoesel approved these changes

View reviewed changes

Member

cmoesel left a comment

Like you, I don't know why the old way didn't work, but I'm glad that the new way does!

cmoesel merged commit 317db69 into master

cmoesel deleted the fix-comments branch

January 24, 2020 20:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

cmoesel cmoesel approved these changes

mint-thompson Awaiting requested review from mint-thompson mint-thompson is a code owner

jafeltra Awaiting requested review from jafeltra jafeltra is a code owner

ngfreiter Awaiting requested review from ngfreiter