Replace file copying command line utility #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cpy-cli package has a deep dependency with a security vulnerability. It is replaced by the copyfiles package. This is used by the build script. The source path is quoted because the copyfiles documentation recommended quoting paths that contain globs.
mint-thompson
requested review from
cmoesel,
jafeltra,
guhanthuran and
julianxcarter
cmoesel
approved these changes
Feb 1, 2022
There was a problem hiding this comment.
It works well on Mac. I had to lookup the docs to see what -u 3 does. Now I get it (although I think it's kind of weird that you need it). Anyway... Perfect. Thanks, @mint-thompson!
julianxcarter
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1004 and completes task CIMPL-875.
The cpy-cli package has a deep dependency with a security vulnerability. It is replaced by the copyfiles package. This is used by the build script. The source path is quoted because the copyfiles documentation recommended quoting paths that contain globs.
To test, run
npm clean-install, which will clear out yournode_modulesdirectory and install based on the updated package requirements. Then, runnpm build, and check to see that thedist/utils/init-projectdirectory contains all the files fromsrc/utils/init-project.