Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It may be not compatible with Obsidian Plugin-Sliding Panes. #1

Closed
wwjCMP opened this issue Dec 20, 2020 · 1 comment · Fixed by #5
Closed

It may be not compatible with Obsidian Plugin-Sliding Panes. #1

wwjCMP opened this issue Dec 20, 2020 · 1 comment · Fixed by #5

Comments

@wwjCMP
Copy link

wwjCMP commented Dec 20, 2020

If the Obsidian Plugin-Sliding Panes has been install, the width of iframe can not be change.
@kankaristo kankaristo mentioned this issue Jan 1, 2021
Merged
@kankaristo
Copy link
Collaborator

This doesn't seem to be caused by the Sliding Panes (Andy's Mode) plugin, the issue persists even if that plugin is disabled (unless Obsidian doesn't completely disable plugins).

But whether that's the case or not, the issue should be fixed with #5.

FHachez added a commit that referenced this issue Jan 22, 2021
@FHachez
Merge pull request #5 from kankaristo/master
d19950d 
- adds a wrapper element around the iframe, mostly to allow automatic height calculation (defaults to 16:9 aspect ratio)
- removes the use of CSS classes
- adds a text input for setting the iframe's height (defaults to automatic 16:9 aspect ratio)
- fixes #1 (was broken for me too)
- improved grammar in README.md and in user-facing messages (use of a/an, proper capitalization)
minor code cleanup (only for parts that were changed anyway)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kankaristo @wwjCMP