Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad default keybinding (Ctrl+Shift+I) #4

Closed
kankaristo opened this issue Jan 1, 2021 · 3 comments
Closed

Bad default keybinding (Ctrl+Shift+I) #4

kankaristo opened this issue Jan 1, 2021 · 3 comments

Comments

@kankaristo
Copy link
Collaborator

Ctrl+Shift+I is a bad default keybinding, because it's is already used in Obsidian (and in Chrome, and most Electron apps) to open the developer tools (useful for modifying CSS, etc.).

The extension's keybinding can be changed in Obsidian's settings, but the default keybinding probably shouldn't conflict with a base Obsidian keybinding (especially since the developer tools keybinding cannot be changed).

@FHachez
Copy link
Owner

FHachez commented Jan 22, 2021

@kankaristo This is indeed a bad conflict what default key do you propose?

I guess it's an issue on Windows where Mod is mapped to CTRL.
I didn't encounter the issue because on mac, Mod is cmd, the shortcut is cmd + shift + I.

@kankaristo
Copy link
Collaborator Author

kankaristo commented Jan 22, 2021

I'm currently using Alt+I, since Alt is rarely used for "default" keybindings (I've set most of my Obsidian plugin keybindings to use Alt + something).

Another option is to not have a default keybinding at all. A lot of Atom plugins/packages take this route, since otherwise there will always be conflicts when you have a few dozen plugins installed (Atom leaves a lot of the "basic" functionality up to packages, so the "core" editor is lightweight).

With no default keybindings or with (eventual) conflicting keybindings, the user will have to modify keybindings anyway. But without default keybindings, at least installing a new plugin doesn't break existing things (but I haven't used Atom for a couple of years, so I'm not sure if not having default keybindings is still common).

But, as long as a plugin's keybindings don't conflict with default Obsidian stuff, I think it's fair to leave it up to the user to manage their plugins' keybindings.

@FHachez
Copy link
Owner

FHachez commented Jan 22, 2021

Thanks for the context and quick response. Let's start with Alt+I and see if we get more feedback.

FHachez added a commit that referenced this issue Jan 22, 2021
- Change default keybinding to `alt + i` 
- #4
- #3
- Add a changelog to the Readme
@FHachez FHachez closed this as completed Jan 22, 2021
@thomasvs thomasvs mentioned this issue May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants