Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added x-client request header to SSE subscription. #13

Merged
merged 1 commit into from
Sep 26, 2018
Merged

Added x-client request header to SSE subscription. #13

merged 1 commit into from
Sep 26, 2018

Conversation

asgeirn
Copy link
Contributor

@asgeirn asgeirn commented Aug 16, 2018 •
edited
Loading

This PR adds x-client as a required header for the /sse/{id} endpoint, and tracks the value for reporting active SSE clients.

It depends on Access Gateway configuration for injecting this header based on OAuth claims, and does not require adapters to provide this header.

@coveralls
Copy link

coveralls commented Aug 16, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 78.261% when pulling d789bf5 on x-client into 62459a8 on event-model-v3.

@asgeirn
Copy link
Contributor Author

asgeirn commented Aug 16, 2018

Verified on /administrasjon/personal/provider for beta. This endpoint has been configured to reject requests without proper OAuth scope.

@fsjovatsen
Copy link
Contributor

fint-provider: 1.5.0

@fsjovatsen fsjovatsen added this to the v1.5.0 milestone Sep 25, 2018
@asgeirn asgeirn merged commit c58ad19 into event-model-v3 Sep 26, 2018
@asgeirn asgeirn deleted the x-client branch September 26, 2018 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsjovatsen fsjovatsen Awaiting requested review from fsjovatsen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asgeirn @coveralls @fsjovatsen