Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<fix>(txpool): fix many small bugs #3899

Merged
merged 12 commits into from Sep 11, 2023
Merged

<fix>(txpool): fix many small bugs #3899

merged 12 commits into from Sep 11, 2023

Conversation

JimmyShi22
Copy link
Member

@JimmyShi22 JimmyShi22 commented Sep 7, 2023 •
edited

  1. Fix m_blockContext nullptr
  2. Fix force sender bug
  3. Fix sharding error log
  4. tx sync p2p faster than rpc bug
  5. timer start() bad_weak_ptr bug

kyonRay
kyonRay previously approved these changes Sep 7, 2023
View reviewed changes
@codecov
Copy link

codecov bot commented Sep 7, 2023 •
edited

Codecov Report

Patch coverage is 36.36% of modified lines.

❗ Current head ccfff1a differs from pull request most recent head c916207. Consider uploading reports for the commit c916207 to get more accurate results

Files Changed Coverage
...cutor/src/executor/ShardingTransactionExecutor.cpp 0.00%
...framework/test/unittests/storage/TestCondition.cpp ø
bcos-protocol/bcos-protocol/TransactionStatus.h ø
bcos-scheduler/src/ShardingBlockExecutive.cpp 0.00%
bcos-scheduler/src/ShardingDmcExecutor.cpp 0.00%
...-txpool/bcos-txpool/txpool/storage/MemoryStorage.h ø
bcos-utilities/bcos-utilities/BucketMap.h 0.00%
bcos-executor/src/executor/TransactionExecutor.cpp 33.33%
...xpool/bcos-txpool/txpool/storage/MemoryStorage.cpp 53.33%
bcos-ledger/src/libledger/Ledger.cpp 100.00%
... and 2 more

📢 Thoughts on this report? Let us know!.

bxq2011hust
bxq2011hust previously approved these changes Sep 7, 2023
View reviewed changes
@JimmyShi22 JimmyShi22 changed the title <fix>(executor): Fix m_blockContext nullptr <fix>(executor): Fix m_blockContext nullptr & fix force sender bug & fix sharding error log Sep 8, 2023
@JimmyShi22 JimmyShi22 changed the title <fix>(executor): Fix m_blockContext nullptr & fix force sender bug & fix sharding error log <fix>(executor): Fix m_blockContext nullptr & fix force sender bug & fix sharding error log & tx sync p2p faster than rpc bug Sep 8, 2023
bxq2011hust
bxq2011hust previously approved these changes Sep 8, 2023
View reviewed changes
@JimmyShi22 JimmyShi22 changed the title <fix>(executor): Fix m_blockContext nullptr & fix force sender bug & fix sharding error log & tx sync p2p faster than rpc bug <fix>(txpool): many small bugs Sep 8, 2023
@JimmyShi22 JimmyShi22 changed the title <fix>(txpool): many small bugs <fix>(txpool): fix many small bugs Sep 11, 2023
bxq2011hust
bxq2011hust previously approved these changes Sep 11, 2023
View reviewed changes
@JimmyShi22 JimmyShi22 merged commit 834885b into FISCO-BCOS:release-3.5.0 Sep 11, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bxq2011hust bxq2011hust bxq2011hust approved these changes

@kyonRay kyonRay kyonRay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JimmyShi22 @bxq2011hust @kyonRay