Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 3.3.0 #760

Merged
merged 26 commits into from
Apr 17, 2023
Merged

Release 3.3.0 #760

merged 26 commits into from
Apr 17, 2023

Conversation

kyonRay
Copy link
Member

@kyonRay kyonRay commented Apr 14, 2023

No description provided.

kyonRay and others added 24 commits January 30, 2023 16:24
@kyonRay
<feat>(precompiled): adapt 3.3 dynamic auth check feature. (FISCO-BCO…
646737b 
…S#724)
@kyonRay
<feat>(precompiled): adapt initAuth method. (FISCO-BCOS#725)
a6028df
@JimmyShi22
<feat>(SardingService): add ShardingService (FISCO-BCOS#727)
d7e4c33 
* add ShardingService

* reformat
@JimmyShi22
fix checkVersion help info (FISCO-BCOS#728)
a2d6b01
@LucasLi1024
add API for HSM (FISCO-BCOS#729)
147c2e8 
Author:  LucasLi
Date：  Thu Feb 16 20:00:33 2023 +0800
@kyonRay
<fix>(consensus): fix add sealer bug when sdk connect observer to be …
bf6ddf4 
…added. (FISCO-BCOS#730)
@ywy2090
<upgrade>: update jackson-databind to v2.4.12 (FISCO-BCOS#731)
546ca54
@kyonRay
<fix>(codec): fix codec struct and multidimensional array bug, deprec…
426e9f9 
…ated Type.class. (FISCO-BCOS#732)

* <fix>(codec): fix codec struct and multidimensional array bug, deprecated Type.class.

* <fix>(codec): fix sol2java function codec bug.
@kyonRay
<feat>(contract): add async call method. (FISCO-BCOS#733)
ffda87c
@kyonRay
<feat>(precompiled): add BFS isExist interface. (FISCO-BCOS#734)
6ea3c82
@kyonRay
<fix>(precompiled): fix bfs isExist bug. (FISCO-BCOS#735)
bbf8ff6
@kyonRay
<fix>(transaction): fix callResponse and trasactionResponse decode in…
f9c2f0e 
…compatibility problem, fix crud retcode. (FISCO-BCOS#739)
@kyonRay
<fix>(precompiled): fix bfs isExist bug, use special judgment logic. (F…
be28ddf 
…ISCO-BCOS#741)
@kyonRay
<fix>(precompiled): fix bfs isExist type judge logic. (FISCO-BCOS#742)
e3f2094
@ywy2090
modify rpc jni interface to reduce memory copy and rpc call times (FI…
7e7f8e3 
…SCO-BCOS#736)

* modify rpc jni interface to reduce memory copy and rpc call times

* add sendRpcRequestToHighestBlockNode config item
@kyonRay
<fix>(transaction): fix assemble transaction with remote sign wrong l…
5bc7275 
…ogic. (FISCO-BCOS#745)
@kyonRay
<fix>(codec): fix scale encode and decode. (FISCO-BCOS#748)
65f8866 
* <fix>(codec): fix scale encode and decode.

* <fix>(codec): fix scale codec test.
@kyonRay
<fix>(test): fix bugs, remove todos. (FISCO-BCOS#751)
3326452
@kyonRay
<fix>(CI): add compatibility node test. (FISCO-BCOS#752)
901e85c
@kyonRay
<fix>(codec): fix codec exception not catch error. (FISCO-BCOS#753)
fed32fd
@kyonRay
<fix>(CI): add sm scene CI. (FISCO-BCOS#754)
657c992
@kyonRay
<fix>(Precompiled): add fixBfs interface to fix BFS index data error. (…
fc10f21 
…FISCO-BCOS#756)
@kyonRay
<fix>(precompiled): fix bfs ABI string bug. (FISCO-BCOS#759)
2499e06
@kyonRay
Merge branch 'release-3.3.0'
7a2be5e
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 14, 2023
View reviewed changes
src/main/java/org/fisco/bcos/sdk/v3/crypto/CryptoSuite.java
} else if (this.cryptoTypeConfig == CryptoType.HSM_TYPE) {
String hsmLibPath = this.config.getCryptoMaterialConfig().getHsmLibPath();
int hsmKeyIndex =
Integer.parseInt(this.config.getCryptoMaterialConfig().getHsmKeyIndex());

Check notice

Code scanning / CodeQL

Missing catch of NumberFormatException

Potential uncaught 'java.lang.NumberFormatException'.
src/main/java/org/fisco/bcos/sdk/v3/codec/scale/TypeDecoder.java
if (elements.isEmpty()) {
return (T) new DynamicArray(AbiTypes.getType(typeName), elements);
}
return (T) new DynamicArray<>(elements);

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation

Invoking [DynamicArray.DynamicArray](1) should be avoided because it has been deprecated.
src/main/java/org/fisco/bcos/sdk/v3/codec/scale/TypeDecoder.java Fixed Show fixed Hide fixed
@kyonRay kyonRay force-pushed the master branch 4 times, most recently from 9d03971 to 361eaa9 Compare April 15, 2023 04:07
@kyonRay kyonRay force-pushed the master branch 8 times, most recently from 0d2f2be to dc6dd8d Compare April 16, 2023 03:25
@codecov
Copy link

codecov bot commented Apr 16, 2023 •
edited
Loading

Codecov Report

Patch coverage: 14.66% and project coverage change: -2.02 ⚠️

Comparison is base (c419ef0) 32.29% compared to head (62d0e00) 30.28%.

❗ Current head 62d0e00 differs from pull request most recent head e00aaf0. Consider uploading reports for the commit e00aaf0 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #760      +/-   ##
============================================
- Coverage     32.29%   30.28%   -2.02%     
+ Complexity     1503     1494       -9     
============================================
  Files           379      385       +6     
  Lines         13729    14516     +787     
  Branches       1542     1649     +107     
============================================
- Hits           4434     4396      -38     
- Misses         8907     9710     +803     
- Partials        388      410      +22
Impacted Files Coverage Δ
...main/java/org/fisco/bcos/sdk/v3/client/Client.java 0.00% <ø> (ø)
.../java/org/fisco/bcos/sdk/v3/client/ClientImpl.java 0.00% <0.00%> (ø)
...fisco/bcos/sdk/v3/codec/wrapper/ABIDefinition.java 56.09% <0.00%> (-3.00%) ⬇️
...os/sdk/v3/codec/wrapper/ContractABIDefinition.java 63.04% <ø> (ø)
...dk/v3/contract/precompiled/bfs/BFSPrecompiled.java 16.94% <0.00%> (-3.89%) ⬇️
...bcos/sdk/v3/contract/precompiled/bfs/BFSUtils.java 0.00% <0.00%> (ø)
...ntract/precompiled/consensus/ConsensusService.java 14.54% <0.00%> (-1.46%) ⬇️
...v3/contract/precompiled/crud/TableCRUDService.java 4.74% <0.00%> (-0.06%) ⬇️
...ract/precompiled/sharding/ShardingPrecompiled.java 0.00% <0.00%> (ø)
...contract/precompiled/sharding/ShardingService.java 0.00% <0.00%> (ø)
... and 42 more

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented Apr 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kyonRay kyonRay merged commit b9be407 into FISCO-BCOS:master Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimmyShi22 JimmyShi22 JimmyShi22 approved these changes

@bxq2011hust bxq2011hust bxq2011hust approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kyonRay @JimmyShi22 @bxq2011hust @LucasLi1024 @ywy2090