result optimization #122
Closed
result optimization #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warnings are found on analyzing the commit a800068. 1 warning:
We recommend to address them as possible, for example, update outdated dependencies, fix the tool's configuration, configure If you are struggling with these errors or warnings, feel free to ask us via chat. 💬 |
ghost
reviewed
Jul 23, 2020
client/common/common.py
Outdated
| @@ -283,9 +283,9 @@ def print_tx_result(outputresults): | |||
| """ | |||
| for result in outputresults: | |||
| if type(result) is bytes: | |||
| print("{}, ".format(bytesToHex(result))) | |||
| print("{}".format(bytesToHex(result)),end='\n') | |||
There was a problem hiding this comment.
[Flake8] missing whitespace after ',' (view)
| Rule |
|---|
E231 |
You can close this issue if no need to fix it. Learn more.
client/common/common.py
Outdated
| continue | ||
| print("{}, ".format(result)) | ||
| print("{}".format(result),end='\n') |
There was a problem hiding this comment.
[Flake8] missing whitespace after ',' (view)
| Rule |
|---|
E231 |
You can close this issue if no need to fix it. Learn more.
Closed
|
在目前的分支已经格式化，感谢提交 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues75 has been completed, but the separator of the returned result is
,. when onlyhellowordis saved, the output ishelloword ,. It's very inhumane.