Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Secure connection to mongodb server, via the new mongoc driver.
Partly fixing issue #903
Note that this is not for the API endpoints that are implemented using the old legacy driver.
The idea is to merge away from the legacy driver asap and no time to be lost ...
Current support of the new mongoc driver
All generic features now use "mongoc" - the new Mongo C driver:
The following API endpoints use "mongoc" - the new Mongo C driver:
The following API endpoints use "mongoc" if Orion-LD is started with the
-experimental
CLI parameter:The following API endpoints use no database access at all, just the subscription cache:
So, without using the old Mongo C++ Legacy driver, it is now possible to:
Back to the pull request:
There are 5 new CLI parameters for the mongocb connection URI:
For further info, please see the issue #903 , especially about
-dbURI
and-dbpwd
.Ah, almost forgot, the whole thing is quite untested ... Volunteers?
What types of changes does your code introduce to the project: Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.
Further comments
It will take months to migrate the entire set of API endpoints to mongoc - 3-4 months full-time ...