Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use case insensitive matching for http request header keys #1227

Conversation

istyf
Copy link

@istyf istyf commented Sep 8, 2022

Proposed changes

This PR fixes #1226 by replacing strcmp with strcasecmp for the four request headers Orionld-Legacy, Performance, NGSILD-Scope and Accept.

Types of changes

What types of changes does your code introduce to the project: Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

I should have added a test for this, but I don't have the correct toolchain setup currently, and wanted to get the issue and PR posted as soon as possible in case there are others that get affected by this.

I have read the CLA Document and I hereby sign the CLA.

@github-actions
Copy link

github-actions bot commented Sep 8, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️

@istyf
Copy link
Author

istyf commented Sep 8, 2022

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Sep 8, 2022
Copy link
Collaborator

@kzangeli kzangeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted, thanks!

@kzangeli
Copy link
Collaborator

kzangeli commented Sep 9, 2022

Seems like the tests are halted due to something I need to do ...
I really don't know what I need to do. I've already accepted the PR.

If no progress on this before, say Tuesday, I'll merge it anyway.
The fix is quite straightforward and I have no doubt whatsoever. It's GOOD.

Would be nice to see the test suite run though ...

@kzangeli
Copy link
Collaborator

kzangeli commented Sep 9, 2022

So, our DevOps expert tells me you need to "enable the Actions on the fork", for the tests to run.
Could you please try that, and we'll see what happens ...

@istyf
Copy link
Author

istyf commented Sep 9, 2022

Something along these lines? https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks

It seems to me that a repo maintainer needs to that, and not the person doing the fork. Right?

@kzangeli
Copy link
Collaborator

kzangeli commented Sep 9, 2022

Only, there isn't any "Workflow(s) awaiting approval". Really don't know what to do.

According to this SOF issue it seems like it's a bug in github ...

@kzangeli kzangeli merged commit 3e27437 into FIWARE:develop Sep 9, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Case sensitive comparison of some headers causes issues in HTTP/2 environments
2 participants