Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should update response of POST /ngsi-ld/v1/entityOperations/create #16

Open
fisuda opened this issue Mar 29, 2021 · 4 comments
Open

Should update response of POST /ngsi-ld/v1/entityOperations/create #16

fisuda opened this issue Mar 29, 2021 · 4 comments

Comments

@fisuda
Copy link
Contributor

fisuda commented Mar 29, 2021

@jason-fox The response of POST /ngsi-ld/v1/entityOperations/create has been changed between Orion-LD 0.7-PRE-105 and 0.7-PRE-107.

  • 0.7-PRE-105
HTTP/1.1 200 OK
Connection: Keep-Alive
Content-Length: 188
Content-Type: application/ld+json
Date: Sat, 27 Mar 2021 22:51:23 GMT

{"@context":"https://context.lab.letsfiware.jp/ngsi-context.jsonld","success":["urn:ngsi-ld:TemperatureSensor:002","urn:ngsi-ld:TemperatureSensor:003","urn:ngsi-ld:TemperatureSensor:004"],"errors":[]}
  • 0.7-PRE-107
HTTP/1.1 201 Created
Connection: Keep-Alive
Content-Length: 109
Content-Type: application/ld+json
Date: Sun, 28 Mar 2021 11:15:32 GMT

["urn:ngsi-ld:TemperatureSensor:002","urn:ngsi-ld:TemperatureSensor:003","urn:ngsi-ld:TemperatureSensor:004"]

When updating the version of Orion-LD to 0.7-PRE-107 or later, the response of 5th request in this tutorial must be also updated.

https://github.com/FIWARE/tutorials.CRUD-Operations/tree/NGSI-LD#five-request

Please see FIWARE/context.Orion-LD#776.

@jason-fox
Copy link
Member

Using ORION_LD_VERSION=0.7.0 the response is matching the pre-existing text:

{
    "@context": "http://context-provider:3000/data-models/ngsi-context.jsonld",
    "success": [
        "urn:ngsi-ld:TemperatureSensor:002",
        "urn:ngsi-ld:TemperatureSensor:003",
        "urn:ngsi-ld:TemperatureSensor:004"
    ],
    "errors": []
}

Can you confirm that FIWARE/context.Orion-LD#776 has fixed the issue and that this issue can be closed?

@fisuda
Copy link
Contributor Author

fisuda commented Mar 29, 2021

The 0.7-PRE-107 is the latest docker image. This issue can be closed by updating ORION_LD_VERSION to 0.7-PRE-107 in .env file. May I update it?

$ docker images | grep orion-ld
fiware/orion-ld                          0.7-PRE-107                    1a423b53e33a   25 hours ago    979MB
fiware/orion-ld                          0.7-PRE-106                    29fff22b88c3   3 days ago      978MB
fiware/orion-ld                          0.7-PRE-105                    9d814ba66390   7 days ago      978MB
fiware/orion-ld                          0.7.0                          373977638d75   10 days ago     978MB

@jason-fox
Copy link
Member

jason-fox commented Mar 29, 2021

Let's do nothing and leave this issue open for now. Better to leave the text alone and incorrect for now and not to pin to an interim build version. I will close this issue once we get a formal 0.7.1 or 0.8.0 release (it should be in the next three weeks or so.)

@fisuda
Copy link
Contributor Author

fisuda commented Mar 29, 2021

I understand.

fisuda added a commit to fisuda/tutorials.CRUD-Operations that referenced this issue Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants