-
Notifications
You must be signed in to change notification settings - Fork 19
Let the marker show up even when not locked in #35
Comments
The actual approach is that all the requests against TourGuide must be authenticated using a |
I would keep this issue open and let analyze it later as we have other priorities |
I think we should get back to this. Guys, what are your thoughts? @FiwareULPGC, would this be a huge change in the client? From the server side, the change shouldn't be a big deal. Still, IMHO, the actual approach makes the user interacts with the Log-in - oauth - IdM authorization, and this change can make the user run the application and not interact with that feature. |
Hi! We think that it would not be too complicated to adapt the client to the proposed approach. If we are going to implement it in a close future, if it is possible, it should be nice to know it in advance, to take it in care for the next planned client refactor and avoiding to refactor the client twice. Thank you! |
Thanks for the feedback! It was planned to be done in this sprint, but I'm afraid is too bit late (we have one week left for this sprint). Do you think is it feasible? If not, @jmcanterafonseca, should we move it to the next sprint? |
yup 2016-04-21 19:08 GMT+02:00 Alberto Martín notifications@github.com:
|
@FiwareULPGC, sever change for this issue is done #92 (waiting for review) |
We have tested your branch (added as remote and merged with a new branch from develop), and the client can't get information if the user is not logged in. We have checked that the last commit is 98f96ed (the same that the PR). Here we detail the steps that we use to test the PR: Get PR:
Build the docker image:
Modify tourguide image:
Launch the tourguide app:
Access to the application using Firefox: Make a request (without log in):
The error message is raised. Log in and repeat the request:
The response with all restaurant data is printed in the console. |
The image is not built (yet) in dockerhub with the changes, so you need to add the changes mapping the host in the docker-compose file (using tourguide:
image: fiware/tutorials.tourguide-app:latest
hostname: tourguide
links:
- orion
- idm
- pepwilma
- idasiotacpp:idas
environment:
- ORION_HOSTNAME=pepwilma
- ORION_NO_PROXY_HOSTNAME=orion
- ORION_PORT=1026
- ORION_PEP_ENABLED=true
- IDAS_PORT=8080
- ORION_SUBSCRIPTIONS_ENABLED=false
- SENSORS_GENERATION_ENABLED=false
- SENSORS_FORCED_UPDATE_ENABLED=false
volumes_from:
- idm
volumes:
- ../../../tutorials.TourGuide-App:/home/tourguide/tutorials.TourGuide-App |
We have followed your indications and we could test it properly (after installing grunt). The client can get information even if the user is not logged in. We also tested forbidden operations like delete and they returned 404 errors (maybe you could consider to return 403 errors instead) Apart from the returned error codes it LGTM. |
I'll open an issue to check that and re-asign this one to @FiwareULPGC . Thanks for the feedback! |
Implemented via #117 |
Literally reported by a user:
"Let the marker show up even when not locked in, this is a unusual behavior for me. Prevent to edit, yes, but not showing?"
The text was updated successfully, but these errors were encountered: