This repository has been archived by the owner on Feb 23, 2021. It is now read-only.
Client style improvements #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| font-weight: bold; | ||
| } | ||
|
|
||
| */ |
There was a problem hiding this comment.
please avoid commented code
|
good work but we certainly need more iterations thanks! |
|
there are still some comments not addressed wrt to CSS and comments, please check |
FiwareULPGC
force-pushed
the
refactor/Client_style_improvements
branch
2 times, most recently
from
56d6a5e
to
8c8a4eb
Compare
- Nomenclature changes (camelCase, use of english, renamed files, etc).
- Translate to DOM syntax.
- Process reviews onsubmit instead of onclick.
- DOM reservationForm. Fixed disabled/enabled form elements.
- Deleted commented code. Delete unnecesary code.
- Removed several console.log lines.
- Used innerHTML= '' instead of removeChild.
- Module pattern implemented.
- Added doctype to HTML files. CSS and JS inclusions have been ordered.
- Fixed authors text.
- Changes to pass linter.
- Roles added as properties.
- Client structure changed.
- Moved bootstrap files to js folder.
- Moved app.css to stylesheets folder.
- Usage of forEach.
- Usage of try-catch avoided.
- Usage of constants.
- Deleted proxy variable.
- Other minor style fixes.
FiwareULPGC
force-pushed
the
refactor/Client_style_improvements
branch
from
8c8a4eb
to
e50ff98
Compare
This was referenced Apr 1, 2016
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request has several style improvements:
With this PR the issues #31 #20 #19 #18 #16 should be solved.
With this PR #21 is partially solved. It will be fully resolved in an upcoming PR that adds linter tests to travis-ci.
Due to the size of this PR and following the developer guidelines ( https://forge.fiware.org/plugins/mediawiki/wiki/fiware/index.php/Developer_Guidelines ), we have rebased the PR semantically. We can reduce the number of commits if it is needed.
We plan to refactorize the modules in a smaller ones in a upcoming PR.