USB HID issue since September 2019 build

[geogolem]

#712

this commit works: f0694cd
but the next commit has the freeze issue: 2746990

so something in 2746990 is related... i think..

i narrowed it down to that line that was added.

I have no idea why this fixed the issue nor do I know
what other potential problems it introduces but it seems to be working

The intention of this PR is not to actually have this line commented out - but rather to draw attention to the issue. The code in this commit/PR is a workaround and potential fix.

Maybe commenting the line out is a good fix, maybe not - but it is a workaround for people who want to use the latest codebase without breaking usbloaderGX. The other option many people are using is simply using a build from prior to this line being introduced. it is probably better if they use the latest codebase, with that line commented out, and if they find any issues then we can investigate further. Anyway, this PR is to document the line I believe introduced the problem even though just commenting the line out may not be the actual fix in the end.

[GaryOderNichts]

I did the same thing on my fork 2 months ago.
GaryOderNichts@55f99ad
I also fixed it by just commenting out that line.
A proper fix would probably be to increase the HID timer which is what commenting out this line simply disables. This will cause the timer to run as fast as possible. This doesn't seem to cause any issues so I just commented this out.
I didn't PR my changes since Nintendont seems to be currently unmaintained.

These changes also seem to only affect the Loader.

[geogolem]

I did the same thing on my fork 2 months ago.
GaryOderNichts@55f99ad
I also fixed it by just commenting out that line.
A proper fix would probably be to increase the HID timer which is what commenting out this line simply disables. This will cause the timer to run as fast as possible. This doesn't seem to cause any issues so I just commented this out.
I didn't PR my changes since Nintendont seems to be currently unmaintained.

These changes also seem to only affect the Loader.

if you have changes, you should PR them anyway. I looked through the PR's to see if anybody fixed that --> it would have saved me some time. :) You should PR it anyway, just in case anybody else wants to update a build or something.. (i notice you also had other changes too... that fix other issues)

[carnage702]

made a version 490 available