Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminating redundant data in Orchestra files #33

Closed
Olivercomputing opened this issue Jun 29, 2018 · 1 comment
Closed

Eliminating redundant data in Orchestra files #33

Olivercomputing opened this issue Jun 29, 2018 · 1 comment
Labels

Comments

@Olivercomputing
Copy link

The ancestor of Orchestra files, the Fix Repository, contains redundant information. For example, a field reference:

<fixr:fieldRef id="5" name="AdvTransType" presence="required" added="FIX.2.7"> [...]

And then a related field definition entry:

<fixr:field id="5" name="AdvTransType" type="AdvTransTypeCodeSet" added="FIX.2.7" abbrName="AdvTransTyp"> [...]

The name attribute in the fieldRef element is redundant. It should always match the name in the field definition. This denormalization is unnecessary and wasteful. The id attribute is sufficient to specify the field reference.

The same also applies to components and groups, and there may be other similar examples.

@donmendelson
Copy link
Member

In GroupType, keep attribute numInGroupId but remove numInGroupName since it is redundant.

donmendelson added a commit to donmendelson/fix-orchestra that referenced this issue Jul 9, 2018
donmendelson added a commit that referenced this issue Jul 18, 2018
XML schema refinements - issues #32 #33 #34 #36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants