Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offsets within composite types #11

Closed
mjpt777 opened this issue Dec 14, 2015 · 5 comments
Closed

Offsets within composite types #11

mjpt777 opened this issue Dec 14, 2015 · 5 comments

Comments

@mjpt777
Copy link

mjpt777 commented Dec 14, 2015

How composites have now been specified I'm unsure about the implementation. How does one specific the offset of an enum, set, or composite within a composite? Only encoded data types seem to carry the offset attribute.

@donmendelson
Copy link
Member

Offset attribute should be shared by all encoding types, including simple type (XML type encodedDataType), enumType, setType, and compositeType (for nested composites, if we choose to create such a thing).

@mjpt777
Copy link
Author

mjpt777 commented Dec 14, 2015

It should be but the schema does not allow it :-)

@donmendelson
Copy link
Member

Understood. Unless someone else would like to jump in with a proposal, I will propose a revised XSD under v1-0-RC4 folder.

@mjpt777 if we can get recent proposals approved quickly, would you like to jump to RC4 in your implementation?

@mjpt777
Copy link
Author

mjpt777 commented Dec 14, 2015

We can jump to RC4 if does not change the scope of the work to be done significantly.

donmendelson added a commit to donmendelson/fix-simple-binary-encoding that referenced this issue Dec 14, 2015
Created new attributeGroup "positionAttributes" and applied it to all encoding types and fields.
donmendelson added a commit to donmendelson/fix-simple-binary-encoding that referenced this issue Dec 14, 2015
@donmendelson
Copy link
Member

The working group suggested changing "positionAttributes" to "alignmentAttributes". Other attributes may be added to the group in the future.

donmendelson added a commit to donmendelson/fix-simple-binary-encoding that referenced this issue Dec 21, 2015
Offset attribute applies to a simple type, enum or bitset within a composite type.
donmendelson added a commit that referenced this issue Dec 21, 2015
Offsets within composite types #11 and #12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants