Skip to content

Commit

Permalink
Bump macOS minimum to 10.9, per cert requirements
Browse files Browse the repository at this point in the history
  • Loading branch information
@flibitijibibo
flibitijibibo committed Mar 4, 2020
1 parent 99b0383 commit 30b6923
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Expand Up @@ -52,7 +52,7 @@ set(CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules")

# Platform Flags
if(APPLE)
set(CMAKE_OSX_DEPLOYMENT_TARGET 10.7)
set(CMAKE_OSX_DEPLOYMENT_TARGET 10.9)
elseif(WIN32)
# "FAudio.dll", not "libFAudio.dll"
set(CMAKE_SHARED_LIBRARY_PREFIX "")
Expand Down

6 comments on commit 30b6923

@ryandesign
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain this change in more detail? What does "per cert requirements" mean?

@flibitijibibo
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some developers notarize their binaries, and notarization requires targeting at least 10.9.

@Gcenx
Copy link

@Gcenx Gcenx commented on 30b6923 Jun 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryandesign seems I never needed that workaround then.

@flibitijibibo that's a misconception, it's never stated the deployment target needs to be 10.9 just the SDK used to compile the software must be 10.9

https://developer.apple.com/documentation/xcode/notarizing_macos_software_before_distribution/resolving_common_notarization_issues#3087723

Using a newer SDK doesn’t affect your binary’s compatibility with earlier versions of macOS. Instead, version compatibility depends on the app’s deployment target, as described in Edit deployment info settings.

You can use the 10.13 SDK and compile down to 10.5

@flibitijibibo
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. FNA has other libraries that require 10.9 for non-cert reasons, so this commit still works for us. I believe you can override this if you want.

@Gcenx
Copy link

@Gcenx Gcenx commented on 30b6923 Jun 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flibitijibibo so to clarify FAudio since this change really does required OS X 10.9 for some extensions or features?

@flibitijibibo
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only if you don’t specify a deployment target yourself. For our purposes it is most convenient to target 10.9, others may want something higher or lower based on their own needs.

Please sign in to comment.