Add missing NULL check in FAudioVoice_SetChannelVolumes #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This value shouldn't be NULL... the only reason it would be is if ... but I'm more concerned about the former. Here are the two spots where https://github.com/FNA-XNA/FAudio/blob/master/src/FAudio.c#L1195 |
|
It looks like ca1729e fixes the issue, so I'll close the PR. Sorry for the noise. |
|
No sorrys needed, that lit up an assert that should have been real error handling. Thanks @exolyte! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash in atelier firis: ValveSoftware/Proton#1486