More iOS fixes #208
More iOS fixes #208
Conversation
src/FNAPlatform/OpenGLDevice.cs
Outdated
| @@ -663,6 +647,17 @@ ref wmInfo | |||
| MojoShader.MOJOSHADER_glMakeContextCurrent(shaderContext); | |||
| FNALoggerEXT.LogInfo("MojoShader Profile: " + shaderProfile); | |||
|
|
|||
| // UIKit needs special treatment for backbuffer behavior | |||
| if (SDL.SDL_GetPlatform() == "iOS" || SDL.SDL_GetPlatform() == "tvOS") | |||
There was a problem hiding this comment.
Was the wminfo data inaccurate? If possible I'd like to get the GLuint handles from SysWMInfo instead, but if something's not right with it then we can do this.
There was a problem hiding this comment.
Yeah, it always returned 0 for both the Framebuffer and Renderbuffer handles, which just put us back where we started.
There was a problem hiding this comment.
I wonder if it’s this part here: https://hg.libsdl.org/SDL/file/80f861112154/src/video/uikit/SDL_uikitwindow.m#l357
Depending on the reason for these results this may be an SDL bug.
There was a problem hiding this comment.
I'm an idiot, we need to initialize the version info first:
The UIKit stuff in master should work now...
|
Other than the 2 comments this LGTM! |
src/FNAPlatform/OpenGLDevice.cs
Outdated
| @@ -4726,4 +4728,4 @@ private void ForceToMainThread(Action action) | |||
|
|
|||
| #endregion | |||
| } | |||
| } | |||
| } | |||
Just a few small changes needed for iOS/tvOS. Of particular note is that
MediaPlayeris a namespace in Xamarin.iOS, so I had to change FrameworkDispatcher to refer toMedia.MediaPlayer. If there's a nicer way to resolve that namespace/classname conflict, that'd be great.