Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add security checks #488

Merged
merged 1 commit into from Dec 23, 2022
Merged

Conversation

skyrider223
Copy link
Contributor

Add security checks to Quick Host Deletion, Update Product Key, Join multicast session and Approve This Host.

Add security checks to Delete computer, Change windows key, Join multicast session and Approve host.
@skyrider223
Copy link
Contributor Author

bootmenu.class.php doesn't verify properly if user is logged or not regarding, thus allowing bad actor to craft arbitrary request to delete computers, change windows key product and approve host.
(eg : http://xxx.xxx.xxx.xxx/fog/service/ipxe/boot.php?mac=XX:XX:XX:XX:XX&delconf=1 )

@Sebastian-Roth
Copy link
Member

@skyrider223 Thanks for sending in a PR. While I see your point of securing those iPXE menu tasks I am wondering if people used to have this unsecured will complain about the change.

@Sebastian-Roth
Copy link
Member

@skyrider223 Would you mind posting a link to this PR in the FOG forums as well to hopefully get some further discussion on this going?

@skyrider223
Copy link
Contributor Author

Hello @Sebastian-Roth,

Sorry for my late reply.
Here we go : https://forums.fogproject.org/topic/16606/add-security-checks-488

Cheers,

@Sebastian-Roth
Copy link
Member

Bumped the topic in the forums.

@Sebastian-Roth Sebastian-Roth added this to the 1.5.10 milestone Dec 12, 2022
@Sebastian-Roth Sebastian-Roth merged commit 0f2350b into FOGProject:dev-branch Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants