Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows 11 to 'os' #503

Closed
wants to merge 1 commit into from
Closed

Conversation

flagoda
Copy link
Contributor

@flagoda flagoda commented Oct 21, 2022

Add Windows 11 osid

@Sebastian-Roth
Copy link
Member

@flagoda Thanks for your pull request on adding Windows 11. Though there is a lot more to consider when doing this.

  1. This would only work for new installs of FOG but it won't add the Windows 11 definition if upgrading from an older version of FOG. The schema updater reads schema version numbers from /var/www/fog/lib/fog/system.class.php and the database and will only add schema changes if system.class.php has a higher version number. As well the schema updater would only add the last schema changes (as many as version numbers differ) - see databasemanager.class.php line 78 to 125 and schemaupdaterpage.class.php line 173ff.
  2. The osid is mostly used by the FOS inits to decide weather certain steps need to be done one way or the other (e.g. Win XP vs. Win 10 vs. Linux vs. macOS). So if we add a new osid for Win 11 a fair amount of changes need to be made to the FOS scripts as well - 1, 2, 3, 4, 5 just to name a few.
  3. Currently we a pretty cautious with adding changes to the schema because two versions of FOG are in development (dev-branch) and (working-1.6). The schema diverged at some stage and it needs thorough consideration when changing the schema.

In general I am wondering if adding Windows 11 as it's own osid is actually a good idea. As long as the FOS inits don't need to handle Win 10 and Win 11 differently I would rather not add a new osid. Maybe we should rather think about changing the name in the drop down list from "Windows 10" to "Windows 10/11".

@flagoda
Copy link
Contributor Author

flagoda commented Oct 24, 2022

To deploy Win 11, i need have an osid different than Win 10, because for example sysprep/setupcomplete/drivers are different between 10 and 11 version.
I will cheat in my own scripts, I thought it would have been easier like that.

@Sebastian-Roth
Copy link
Member

@flagoda Ok, thanks for your reply. I will close this as wontfix then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants