Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

686 logging typos #688

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

686 logging typos #688

wants to merge 3 commits into from

Conversation

kevinpowell1
Copy link
Contributor

No description provided.

@kevinpowell1 kevinpowell1 linked an issue Sep 28, 2023 that may be closed by this pull request
Copy link
Contributor Author

@kevinpowell1 kevinpowell1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more typo fixes

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #688 (3b7fd1f) into main (c987869) will increase coverage by 0.05%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main     #688      +/-   ##
==========================================
+ Coverage   70.70%   70.75%   +0.05%     
==========================================
  Files         101      101              
  Lines       11038    11030       -8     
  Branches     1335     1331       -4     
==========================================
  Hits         7804     7804              
+ Misses       2941     2937       -4     
+ Partials      293      289       -4     
Flag Coverage Δ
unittests 70.75% <85.71%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/folio_migration_tools/__main__.py 27.47% <ø> (ø)
..._tools/mapping_file_transformation/order_mapper.py 87.05% <100.00%> (ø)
...mapping_file_transformation/organization_mapper.py 84.92% <100.00%> (+5.06%) ⬆️
...ation_tools/migration_tasks/migration_task_base.py 31.79% <ø> (ø)
...ng_file_transformation/mapping_file_mapper_base.py 83.92% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinpowell1 Looks like this snuck in. Can we remove it, please?

Copy link
Collaborator

@bltravis bltravis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions inline.

)
else:
self.address_categories_map = None
self.address_categories_map = RefDataMapping(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem like fixing typos. Was this included intentionally?

@bltravis
Copy link
Collaborator

bltravis commented Oct 9, 2023

@kevinpowell1 Can you have a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging Typos
2 participants