Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store (origin, neighbor) combinations of hijack BGP updates in redis (Closes #119) #120

Merged
merged 2 commits into from
Mar 4, 2019
Merged

Store (origin, neighbor) combinations of hijack BGP updates in redis (Closes #119) #120

merged 2 commits into from
Mar 4, 2019

Conversation

vkotronis
Copy link
Member

Description of PR

What component(s) does this PR affect?

  • Back-End (Database, Microservices, Containers, etc)
  • Front-End (Flask, API, etc)
  • Docs
  • Build System

database and detection

Does the PR require changes on other components? If yes, please mark the components:

  • Back-End (Database, Microservices, Containers, etc)
  • Front-End (Flask, API, etc)
  • Docs
  • Build System

Related Issue

Resolves #119

Solution

Added the origin, neighbor combinations as strings in redis sets related to ongoing hijacks

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • None of the above

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.

@vkotronis vkotronis added this to the release-1.2.0 milestone Feb 28, 2019
@vkotronis vkotronis self-assigned this Feb 28, 2019
@vkotronis vkotronis added this to In progress in conf_learning via automation Feb 28, 2019
@vkotronis
Copy link
Member Author

@slowr @pgigis this PR is properly tested. Please check whether sth is amiss in the code and approve.

conf_learning automation moved this from In progress to Reviewer approved Mar 1, 2019
@vkotronis vkotronis merged commit a907316 into master Mar 4, 2019
conf_learning automation moved this from Reviewer approved to Done Mar 4, 2019
@vkotronis vkotronis deleted the redis_as_combo branch March 4, 2019 12:49
@vkotronis vkotronis mentioned this pull request May 15, 2019
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slowr slowr slowr approved these changes

@pgigis pgigis pgigis approved these changes

Assignees

@vkotronis vkotronis

Labels
backend database detection p/medium Medium priority
Projects
No open projects
conf_learning
  
Done
Milestone
release-1.2.0
Development

Successfully merging this pull request may close these issues.

Store (origin, neighbor) combinations of hijack BGP updates in redis
3 participants
@vkotronis @slowr @pgigis