-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate local RC feeds (exabgp/hist) into ARTEMIS configuration primitives #254
Conversation
40c61fb
to
5e58ac3
Compare
🏃 Benchmark Results 🏃
|
9fc0f25
to
a8ec7a5
Compare
TODO: |
a8ec7a5
to
8f7e23f
Compare
ca2e592
to
121e790
Compare
Codecov Report
@@ Coverage Diff @@
## master #254 +/- ##
==========================================
+ Coverage 88.43% 89.48% +1.04%
==========================================
Files 6 6
Lines 1652 1864 +212
==========================================
+ Hits 1461 1668 +207
- Misses 191 196 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉 we can imporve the tester/autoconftester configuration afterwards
🏃 Benchmark Results 🏃
|
🏃 Benchmark Results 🏃
|
🏃 Benchmark Results 🏃
|
🏃 Benchmark Results 🏃
|
🏃 Benchmark Results 🏃
|
Description of PR
What component(s) does this PR affect?
Configuration, Monitor, ExaBGP taps
Does the PR require changes on other components? If yes, please mark the components:
Related Issue
Resolves #253
Solution
Instruction to monitor (via configuration) to auto-update configuration based on local monitor feed.
Type
Checklist:
Need to update https://github.com/FORTH-ICS-INSPIRE/artemis/wiki#receiving-bgp-feed-from-local-routerroute-reflectorbgp-monitor-via-exabgp and https://github.com/FORTH-ICS-INSPIRE/artemis/wiki/Configuration-file to let users know that they can use the autoconf flag for exabgp to auto-generate conf file entries. (after completion, testing and merging, ignore for now).