Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session Cookies on Fetch Request (fixes #39) #40

Merged
merged 2 commits into from Jan 16, 2019
Merged

Session Cookies on Fetch Request (fixes #39) #40

merged 2 commits into from Jan 16, 2019

Conversation

slowr
Copy link
Member

@slowr slowr commented Jan 16, 2019

Description of PR

What component(s) does this PR affect?

  • Back-End (Database, Microservices, Containers, etc)
  • Front-End (Flask, API, etc)
  • Docs
  • Build System

Does the PR require changes on other components? If yes, please mark the components:

  • Back-End (Database, Microservices, Containers, etc)
  • Front-End (Flask, API, etc)
  • Docs
  • Build System

Related Issue

#39

Solution

Attached session cookie to fetch request because older browsers did not do that by default.

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • None of the above

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.

@slowr slowr added bug Something isn't working frontend labels Jan 16, 2019
@slowr slowr added this to In progress in frontend via automation Jan 16, 2019
@slowr slowr self-assigned this Jan 16, 2019
frontend automation moved this from In progress to Reviewer approved Jan 16, 2019
@slowr slowr merged commit aff98a4 into master Jan 16, 2019
frontend automation moved this from Reviewer approved to Done Jan 16, 2019
@slowr slowr deleted the fetch_fix branch January 16, 2019 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Projects
frontend
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants