Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

having issues with the mnet3 branch #115

Closed
justinjohn0306 opened this issue Dec 8, 2023 · 8 comments
Closed

having issues with the mnet3 branch #115

justinjohn0306 opened this issue Dec 8, 2023 · 8 comments
Assignees
Labels
bug Something isn't working tensorflow problems Problems caused by the tensorflow framework

Comments

@justinjohn0306
Copy link

Here's a screenshot of the error i'm facing after the initialization of the mnet3 branch of the repo. The cmd line I used for the test: ./MocapNET2CSV --from con0014/2dJoints_v1.4.csv --ik 0.001 15 30 --mt --show 3 --hands --label s10-p01-c0014-f --seriallength 4 --gdpr

Screenshot from 2023-12-08 11-31-34

@AmmarkoV AmmarkoV self-assigned this Dec 8, 2023
@AmmarkoV AmmarkoV added bug Something isn't working tensorflow problems Problems caused by the tensorflow framework labels Dec 8, 2023
@AmmarkoV
Copy link
Collaborator

AmmarkoV commented Dec 8, 2023

Unfortunately the error looks like something has internally changed in the way tensorflow restores and executes saved model signatures (?).

My MNET3 code relies on tensorflow CPP bindings :
https://www.tensorflow.org/api_docs/cc
using this wrapper :
https://github.com/FORTH-ModelBasedTracker/MocapNET/blob/master/src/Tensorflow2/tensorflow2.h

The MNET3 training data was produced in 2021 with TF 2.3.1 so this might mean that tensorflow has broken compatibility https://www.tensorflow.org/guide/versions ?

If that is the case the fix would be to :

  1. dump the old models to a different format e.g. ONNX and add a wrapper for ONNX execution
  2. Retrain the models from scratch and save them using the new convention, however these would be new models
  3. somehow Upgrade TF2.3 models to the new version ?

The best I can offer at the time is the python MNET4 backend that has body + hands + face.. :(
https://colab.research.google.com/github/FORTH-ModelBasedTracker/MocapNET/blob/mnet4/mocapnet4.ipynb

Unfortunately if this is a compatibility problem it is hard to fix

AmmarkoV added a commit that referenced this issue Dec 8, 2023
…eed to repack it.. Found it thanks to issue #115 reverting to ammar.gr for files for now..
@AmmarkoV
Copy link
Collaborator

AmmarkoV commented Dec 8, 2023

I think there is a problem with the Google Drive model files..!
I reverted back to the ammar.gr version of the files and I think it fixes the issue, please confirm!

but also keep in mind the new version :
https://colab.research.google.com/github/FORTH-ModelBasedTracker/MocapNET/blob/mnet4/mocapnet4.ipynb

@AmmarkoV
Copy link
Collaborator

AmmarkoV commented Dec 8, 2023

@justinjohn0306 I have also updated the Google Drive files and they work once again.
Will keep the issue open until you confirm!

@justinjohn0306
Copy link
Author

@justinjohn0306 I have also updated the Google Drive files and they work once again. Will keep the issue open until you confirm!

It works now but the output joints from the bvh file is messed up, as you can see in the image below

Screenshot from 2023-12-10 12-06-47

@justinjohn0306
Copy link
Author

justinjohn0306 commented Dec 10, 2023

I think there is a problem with the Google Drive model files..! I reverted back to the ammar.gr version of the files and I think it fixes the issue, please confirm!

but also keep in mind the new version : https://colab.research.google.com/github/FORTH-ModelBasedTracker/MocapNET/blob/mnet4/mocapnet4.ipynb

I did test the mnet4 branch and it wasn't accurate with the pose estimation with the mediapipe module

@ArEnSc
Copy link

ArEnSc commented Dec 10, 2023

we are running into the same issues as @justinjohn0306 here

@ArEnSc
Copy link

ArEnSc commented Dec 10, 2023

@AmmarkoV

@AmmarkoV
Copy link
Collaborator

Since the issue with model package is resolved, and the inverted arms is another issue
I am opening a new issue ticket ( #116 ) and closing this as resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tensorflow problems Problems caused by the tensorflow framework
Projects
None yet
Development

No branches or pull requests

3 participants